Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasm32-unknown-unknown #184

Merged
merged 13 commits into from
Apr 25, 2024
Merged

wasm32-unknown-unknown #184

merged 13 commits into from
Apr 25, 2024

Conversation

decahedron1
Copy link
Member

@decahedron1 decahedron1 commented Apr 11, 2024 •
edited
Loading

Initial support for the wasm32-unknown-unknown target, ref #75.

@decahedron1 decahedron1 added help wanted Extra attention is needed p: high high priority labels Apr 11, 2024
@decahedron1 decahedron1 self-assigned this Apr 11, 2024
@decahedron1 decahedron1 linked an issue Apr 11, 2024 that may be closed by this pull request
Support for wasm32-unknown-unknown #75
Closed
@decahedron1 decahedron1 added the needs testing relevant feature is implemented but needs further testing/debugging label Apr 13, 2024
@decahedron1 decahedron1 marked this pull request as ready for review April 13, 2024 22:48
@codecov Codecov
Copy link

codecov bot commented Apr 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 46.80%. Comparing base (0efd082) to head (f4303e7).
Report is 6 commits behind head on main.

Files Patch % Lines
src/wasm.rs 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
+ Coverage   38.63%   46.80%   +8.16%     
==========================================
  Files          25       26       +1     
  Lines        1786     1673     -113     
==========================================
+ Hits          690      783      +93     
+ Misses       1096      890     -206

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@decahedron1 decahedron1 mentioned this pull request Apr 23, 2024
Closed
@decahedron1 decahedron1 merged commit b12c43c into main Apr 25, 2024
8 of 9 checks passed
@decahedron1 decahedron1 deleted the wasm32-unknown-unknown branch October 19, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@decahedron1 decahedron1

Labels
help wanted Extra attention is needed needs testing relevant feature is implemented but needs further testing/debugging p: high high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for wasm32-unknown-unknown
1 participant
@decahedron1