fix: do not lock api pointer #160
Merged
+30
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous
api()behavior was a remnant fromnbigaouette/onnxruntime-rs. I am not sure why we need aMutexhere, or whyapi()unsafely dereferences the pointer, or why we need toget_mut()on theAtomicPtr. Refactoring the code to forego aMutexand do a regular atomic load on the pointer fixes #157 (more on Discord), in which a SIGSEGV was encountered when multiple sessions were being created simultaneously from different threads.