Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add main workflow #19

Merged
merged 14 commits into from
Apr 4, 2024
Merged

Add main workflow #19

merged 14 commits into from
Apr 4, 2024

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Mar 31, 2024

Ποιο issue κλείνει το συγκεκριμένο PR;

Closes #17
Closes #5

Περιγραφή του PR

To PR:

  • Κάνει update στο check_spelling script.
  • Έχει ως τεστ αρχειο το about.po ωστε να είμαστε σίγουροι πως οι έλεγχοι δουλεύουν.

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

άφησα μερικά comments, έχω την εντύπωση ότι πρέπει να βρούμε μια καλύτερα λέξη/φράση για το documentation.

requirements.txt Outdated Show resolved Hide resolved
.github/workflows/main.yaml Outdated Show resolved Hide resolved
.github/workflows/main.yaml Outdated Show resolved Hide resolved
about.po Outdated Show resolved Hide resolved
about.po Outdated Show resolved Hide resolved
about.po Outdated Show resolved Hide resolved
thepetk and others added 5 commits April 2, 2024 15:19
Co-authored-by: Lysandros Nikolaou <[email protected]>
Co-authored-by: Lysandros Nikolaou <[email protected]>
Co-authored-by: Lysandros Nikolaou <[email protected]>
Co-authored-by: Lysandros Nikolaou <[email protected]>
Co-authored-by: Lysandros Nikolaou <[email protected]>
@thepetk
Copy link
Contributor Author

thepetk commented Apr 2, 2024

άφησα μερικά comments, έχω την εντύπωση ότι πρέπει να βρούμε μια καλύτερα λέξη/φράση για το documentation.

Πολύ καλό point. Θα έλεγα μήπως τεκμηρίωση;

Έλεγα μήπως να δημιουργούσαμε ένα yaml αρχείο με conventions - όπου field θα ήταν η αγγλική λέξη και στο value θα ήταν η ελληνική μετάφραση που προτείνουμε.

Π.χ

contributors: συντελεστές

@thepetk thepetk requested a review from lysnikolaou April 2, 2024 14:31
@gzisopoulos
Copy link
Contributor

gzisopoulos commented Apr 2, 2024

Νομιζω για το documentation η καλυτερη λεξη ειναι το Εγχειρίδιο, ισως και το Οδηγίες?

@thepetk thepetk merged commit 1d9ed30 into main Apr 4, 2024
1 check passed
@thepetk thepetk deleted the ft/add_main_workflow branch April 4, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[3.12] Translate about.po Create CI/CD workflows
3 participants