Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iChannelResolution uniform #18

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Add iChannelResolution uniform #18

merged 3 commits into from
Feb 7, 2024

Conversation

Vipitis
Copy link
Collaborator

@Vipitis Vipitis commented Jan 23, 2024

part of #4

iChannelResolution[4] is an array of length 4. Each vec3 has the shape (x, y, aspect). Where pixel-aspect is always 1.0 it seems. reference
Due to the shape, padding is needed. Padding is set to -99. Perhaps there is a better solution for this.

Todos:

  • add uniform for glsl
  • add uniform for wgsl (also test this)
  • improve example/test (also dependencies!)

@Vipitis Vipitis marked this pull request as ready for review January 23, 2024 18:47
@Vipitis Vipitis requested a review from Korijn February 7, 2024 18:36
@Vipitis Vipitis merged commit 206a007 into main Feb 7, 2024
11 checks passed
@Vipitis Vipitis deleted the ichannel-resolution branch February 7, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants