This repository has been archived by the owner on Aug 15, 2021. It is now read-only.
Use serde::ser::StdError
shim type rather than std::error::Error
#180
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for
alloc
vs.std
modes compatibility, a code commentexplains in detail the purpose of this, which is admittedly subtle.
After this commit, builds like
succeed locally for me.
I'm evaluating using cbor in a large
project, I think a patch like this would be super helpful to us.
The gist of it is, we have a bunch of SGX enclaves written in rust,
and servers that pass messages to them in rust. I would like to use
cbor/alloc
in the enclaves to deserialize messages across the FFIboundary.
It would be great if
no_std
infra crates (that get used in both servers and enclacves) in our codebasecan unconditionally select
cbor/alloc
, omit any reference to anstd
flag (to minimizeconfiguration), and these crates can be consumed both by enclaves, and
by servers that also rely on third party crates from crates.io that may enable
serde/std
. I think this patch will make that possible, I'm going to test it.