fix: make sure eic roles are populated correctly #235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes parsing of the EiC role (when it exists) i our review metadata population.
There were a few issues
✅ the field serializer and the validator were not setup to include packages_eic
✅ eic wasn't a role in our contrib_roles object for the review model so that field wasn't being processed. As such when Chiara added her name which was missing, it was deleted in the next bot update. This is now fixed
This pr doesn't have tests yet but we should add some integration tests that ensure contrib data are processed correctly. and then another test to check serialization to yaml