Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure eic roles are populated correctly #235

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

lwasser
Copy link
Member

@lwasser lwasser commented Nov 22, 2024

This fixes parsing of the EiC role (when it exists) i our review metadata population.
There were a few issues

✅ the field serializer and the validator were not setup to include packages_eic
✅ eic wasn't a role in our contrib_roles object for the review model so that field wasn't being processed. As such when Chiara added her name which was missing, it was deleted in the next bot update. This is now fixed

This pr doesn't have tests yet but we should add some integration tests that ensure contrib data are processed correctly. and then another test to check serialization to yaml

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.06%. Comparing base (fb5e6f1) to head (ea94efc).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   73.99%   74.06%   +0.07%     
==========================================
  Files          10       10              
  Lines         669      671       +2     
  Branches       82       82              
==========================================
+ Hits          495      497       +2     
  Misses        166      166              
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lwasser lwasser merged commit e65fe59 into pyOpenSci:main Nov 22, 2024
4 checks passed
@lwasser lwasser deleted the names-eic branch November 22, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant