-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sphinx docs #477
Sphinx docs #477
Conversation
Also, someone, please, resolve those merge conflicts in |
Blocked by #478? |
Since this is merging to |
GitHub allows creating PRs even with branches, where you don't have push access. So I created I also can't change the source branch ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wayyyyyyy better than what we have currently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR merges
sphinx-docs
branch, so it wouldn't produce merge conflicts (like #465) as suggested @ItsDrike in Discord.Note that documentation, in general, is not fully done. Parts (such as FAQ) are still in WIP. I'm also planning to add some "Quick Start" docs, simple examples, etc. but it's in my To-Do now.
There is also a still open conversation by @ItsDrike, which suggests removing
mcstatus.dns
from public API (see discussion on GitHub and in Discord).So, this PR does not close the documentation To-Do - #136.