Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce uv #133

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Introduce uv #133

wants to merge 11 commits into from

Conversation

stankudrow
Copy link
Contributor

@stankudrow stankudrow commented Dec 19, 2024

This PR introduces uv - a unified Python package manager from Astral team - authors of the famous ruff linter.

This PR:

References:

@stankudrow stankudrow marked this pull request as draft December 19, 2024 12:27
setup.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to find a way to emit the same warning. Maybe an import loader, I'm not sure. But it's the most important part here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remind, please, what warning?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment is on the setup.py file. There's a warning there...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once this goes through, there will be no setup.py file -- so ????

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it needs someone to investigate how the same behavior can be maintained.

@stankudrow
Copy link
Contributor Author

@ChrisBarker-NOAA , hello, I need your review as well.

Copy link

@ChrisBarker-NOAA ChrisBarker-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only stopper here is cleaning up the license issues, otherwise, just some thoughts :-)

@@ -0,0 +1,59 @@
[project]
name = "bson"
version = "0.5.10"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep this as is for now -- but the next step would be to introduce some dynamic versioning.

Hatch seems to prefer using its "version" command:

https://waylonwalker.com/hatch-version/

https://hatch.pypa.io/1.2/version/

Personally, I like there to be a __version__ string in the __init__.py.

I know that's a bit controversial, but it doesn't really harm anything, as long as it's all dynamically managed -- I think you can do that with hatch version by:

[tool.hatch.version]
path = "bson/__init__.py"

but I haven't tested it.

Anyway, I don't think we need to hold up this PR for that -- it can come later with some more thought and experimentation.

Copy link

@ChrisBarker-NOAA ChrisBarker-NOAA Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: just tested it, telling hatch to find the version in __init__.py works fine -- so I think this is the way to go.

setup.py Outdated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once this goes through, there will be no setup.py file -- so ????

@ChrisBarker-NOAA
Copy link

I think authorship and licensing needs some cleanup -- but no need to delay this PR for that -- merge away!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants