Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pipeline #131

Merged
merged 10 commits into from
Dec 18, 2024
Merged

Add pipeline #131

merged 10 commits into from
Dec 18, 2024

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Dec 18, 2024

No description provided.

@stankudrow stankudrow mentioned this pull request Dec 18, 2024
@Kludex Kludex merged commit f33aae8 into master Dec 18, 2024
7 checks passed
@Kludex Kludex deleted the add-pipeline branch December 18, 2024 21:26
python-version: ${{ matrix.python-version }}

- name: Run tests
run: uv run --with python-dateutil --with six test.py

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is odd -- tests are failing, but appear to pass ....

And can we use pytest ? -- only 'cause I like it -- it give far more useful info on failure. I think that would take somethign like:

run: uv run --with python-dateutil --with six --with pytest pytest --pyargs bson

though I don't really know uv ...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's it failing?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the remove py2 PR, and is showed as passing, but it was failing, at least on py3.9.

https://github.com/py-bson/bson/actions/runs/12401626827/job/34621412735

But I've fixed that now -- so it all passes now.

(I also changed the test run to pytest in the workflow file in that PR -- maybe shouldn't have mixed and matched , but ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants