Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bson gitignore #128

Closed
wants to merge 1 commit into from

Conversation

stankudrow
Copy link
Contributor

Template: https://github.com/github/gitignore/blob/main/Python.gitignore

Partially covers: #126 - extracting only the .gitignore file updates
Partially addresses: #127

# pyenv
# For a library or package, you might want to ignore these files since the code is
# intended to run in multiple environments; otherwise, check them in:
.python-version
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kludex , should it be commented or not? There is an answer, but your decision will be final.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add the .python-version to the gitignore, yes.

But I don't think we need to add that many things to the .gitignore, only add when things are needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which would you like to keep here definitely? I think I can remove other project management packages, but what else?

Comment on lines -51 to -52
# Django stuff:
*.log
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to keep or not?

@@ -8,7 +8,6 @@ __pycache__/

# Distribution / packaging
.Python
env/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved down to the "Environment" section.

Comment on lines +84 to +85
# mkdocs documentation
/site
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making it stay or go?

@stankudrow stankudrow requested a review from Kludex December 18, 2024 20:48
@stankudrow
Copy link
Contributor Author

Rebased.

Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I said before, I prefer to have files added to the .gitignore when needed.

@Kludex Kludex closed this Dec 19, 2024
@stankudrow stankudrow deleted the update-gitignore branch December 19, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants