Remove PyPI token from publish.yml workflow #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kandersolar I assume one can simply just remove the token and password which would be nice to eliminate (so people can't print the PyPI token or password in a malicious PR) |
|
+1 from me. Let's try it out on another pre-release like you suggested.
IIRC, GitHub Actions redacts secrets that it detects being printed out in logs, but of course the broader point of not having long-lived secrets available to CI jobs is still a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change in method was initiated by a comment raised here.
I have added the pvlib/twoaxistracking/.github/workflows/publish.yml file as a trusted publisher.