Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix too aggressive Map/MapOf shrinking on deletion leading to out of range panic #113

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

puzpuzpuz
Copy link
Owner

@puzpuzpuz puzpuzpuz commented Nov 14, 2023

Fixes #112

@puzpuzpuz puzpuzpuz added the bug Something isn't working label Nov 14, 2023
@puzpuzpuz puzpuzpuz self-assigned this Nov 14, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (42e3390) 98.25% compared to head (4550ef2) 98.25%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   98.25%   98.25%           
=======================================
  Files           8        8           
  Lines        1147     1147           
=======================================
  Hits         1127     1127           
  Misses         16       16           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puzpuzpuz puzpuzpuz merged commit 1386eb4 into main Nov 14, 2023
8 checks passed
@puzpuzpuz puzpuzpuz deleted the fix_too_aggressive_map_shrinking branch November 14, 2023 17:09
@puzpuzpuz puzpuzpuz changed the title Fix too agressive Map/MapOf shrinking on deletion leading to out of range panic Fix too aggressive Map/MapOf shrinking on deletion leading to out of range panic Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic on Compute
2 participants