Use staticcheck instead of golint (#35)

.github/workflows/build-1.18.yml

@@ -0,0 +1,23 @@
+name: build-1.18
+on: [push]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        go-version: [1.18.0-rc1]
+    name: Build with Go ${{ matrix.go-version }}
+    steps:
+      - uses: actions/[email protected]
+      - name: Install Go
+        uses: actions/setup-go@v2
+        with:
+          stable: false
+          go-version: ${{ matrix.go-version }}
+
+      - name: Run tests
+        run: go test -v ./...
+
+      - name: Run tests with race detector
+        run: go test -timeout 10m -race -v ./...

.github/workflows/build.yml

@@ -6,7 +6,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        go-version: [1.16.x, 1.17.x, 1.18.0-rc1]
+        go-version: [1.16.x, 1.17.x]
     name: Build with Go ${{ matrix.go-version }}
     steps:
       - uses: actions/[email protected]
@@ -16,16 +16,16 @@ jobs:
           stable: false
           go-version: ${{ matrix.go-version }}
 
-      - name: Install golint
-        run: go get -u golang.org/x/lint/golint
+      - name: Install staticcheck
+        run: go get honnef.co/go/tools/cmd/staticcheck
 
       - name: Run linters
         run: |
           go vet ./...
-          golint -set_exit_status=1 ./...
+          staticcheck ./...
 
       - name: Run tests
         run: go test -v ./...
 
       - name: Run tests with race detector
-        run: go test -race -v ./...
+        run: go test -timeout 10m -race -v ./...

counter.go

@@ -33,7 +33,8 @@ type Counter struct {
 }
 
 type cstripe struct {
-	c   int64
+	c int64
+	//lint:ignore U1000 prevents false sharing
 	pad [cacheLineSize - 8]byte
 }
 

map.go

@@ -71,7 +71,8 @@ type mapTable struct {
 }
 
 type counterStripe struct {
-	c   int64
+	c int64
+	//lint:ignore U1000 prevents false sharing
 	pad [cacheLineSize - 8]byte
 }
 

mpmcqueue.go

@@ -15,16 +15,19 @@ import (
 // Based on the data structure from the following C++ library:
 // https://github.com/rigtorp/MPMCQueue
 type MPMCQueue struct {
-	cap   uint64
-	head  uint64
-	hpad  [cacheLineSize - 8]byte
-	tail  uint64
+	cap  uint64
+	head uint64
+	//lint:ignore U1000 prevents false sharing
+	hpad [cacheLineSize - 8]byte
+	tail uint64
+	//lint:ignore U1000 prevents false sharing
 	tpad  [cacheLineSize - 8]byte
 	slots []slot
 }
 
 type slot struct {
 	slotInternal
+	//lint:ignore U1000 prevents false sharing
 	pad [cacheLineSize - unsafe.Sizeof(slotInternal{})]byte
 }
 

rbmutex_test.go

@@ -140,6 +140,7 @@ func benchmarkRBMutex(b *testing.B, localWork, writeRatio int) {
 			foo++
 			if writeRatio > 0 && foo%writeRatio == 0 {
 				m.Lock()
+				//lint:ignore SA2001 critical section is empty in this benchmark
 				m.Unlock()
 			} else {
 				tk := m.RLock()
@@ -194,6 +195,7 @@ func benchmarkRWMutex(b *testing.B, localWork, writeRatio int) {
 			foo++
 			if writeRatio > 0 && foo%writeRatio == 0 {
 				m.Lock()
+				//lint:ignore SA2001 critical section is empty in this benchmark
 				m.Unlock()
 			} else {
 				m.RLock()