style(lint): renaming in pagination to replace Id with ID (#58) #18
AlexHashgraphAnnotations
10 errors and 12 warnings
|
Lint:
pagination/psql_pagination.go#L163
fmt.Sprintf can be replaced with string concatenation (perfsprint)
|
|
Lint:
pagination/psql_pagination.go#L169
fmt.Sprintf can be replaced with string concatenation (perfsprint)
|
|
Lint:
pagination/psql_pagination_test.go#L393
expected-actual: need to reverse actual and expected values (testifylint)
|
|
Lint:
pagination/psql_pagination_test.go#L38
test helper function should start from t.Helper() (thelper)
|
|
Lint:
pagination/cursor.go#L81
variable name 'v' is too short for the scope of its usage (varnamelen)
|
|
Lint:
pagination/cursor.go#L70
if statements should only be cuddled with assignments (wsl)
|
|
Lint:
pagination/cursor.go#L73
if statements should only be cuddled with assignments (wsl)
|
|
Lint:
pagination/cursor.go#L76
return statements should not be cuddled if block has more than two lines (wsl)
|
|
Lint:
pagination/psql_pagination.go#L164
return statements should not be cuddled if block has more than two lines (wsl)
|
|
Lint:
pagination/psql_pagination.go#L170
return statements should not be cuddled if block has more than two lines (wsl)
|
|
Test
Restore cache failed: Dependencies file is not found in /home/runner/work/go-commons/go-commons. Supported file pattern: go.sum
|
|
Lint
The following actions uses Node.js version which is deprecated and will be forced to run on node20: golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Lint:
pagination/cursor_internal_test.go#L23
unused-parameter: parameter 'i' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Lint:
pagination/cursor_internal_test.go#L36
unused-parameter: parameter 'i' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Lint:
pagination/cursor.go#L12
exported: exported const UUID_Length should have comment or be unexported (revive)
|
|
Lint:
pagination/cursor_internal_test.go#L49
unused-parameter: parameter 'i' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Lint:
pagination/cursor_internal_test.go#L95
line-length-limit: line is 130 characters, out of limit 100 (revive)
|
|
Lint:
pagination/cursor_internal_test.go#L107
line-length-limit: line is 129 characters, out of limit 100 (revive)
|
|
Lint:
pagination/cursor_internal_test.go#L171
line-length-limit: line is 125 characters, out of limit 100 (revive)
|
|
Lint:
pagination/cursor_internal_test.go#L176
line-length-limit: line is 125 characters, out of limit 100 (revive)
|
|
Lint:
pagination/cursor_internal_test.go#L199
line-length-limit: line is 125 characters, out of limit 100 (revive)
|
|
Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/go-commons/go-commons. Supported file pattern: go.sum
|