Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installdir parameter not defined in install_shell task #399

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kkarthee
Copy link

@kkarthee kkarthee commented Apr 3, 2019

installdir parameter not defined in install_shell task, Due to that install_shell task is failing with the following error.

Error: Task finished with exit-code 1 
This module depends on the puppetlabs-facts module

kkarthee added 2 commits April 3, 2019 14:19
Add install_dir parameter  and correct misspell PT__installdir to PT_installdir
@puppetcla
Copy link

CLA signed by all contributors.

@donoghuc
Copy link
Contributor

The _installdir is a task metaparameter used by bolt for tasks that require multiple files for execution. IN this case, the install_shell task requires files

{"name": "install_shell.sh", "requirements": ["shell"], "files": ["facts/tasks/bash.sh"], "input_method": "environment"},
provided by the https://github.com/puppetlabs/puppetlabs-facts facts module.

@donoghuc
Copy link
Contributor

Also, if you were trying to run the puppet_agent::install_shell task directly, there was likely an error due to #439 . Thanks for submitting this issue.

@gimmyxd gimmyxd requested a review from a team September 27, 2019 11:45
@ciprianbadescu ciprianbadescu changed the base branch from master to main September 15, 2020 10:52
@ciprianbadescu ciprianbadescu requested a review from a team as a code owner September 15, 2020 10:52
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@joshcooper
Copy link
Contributor

@donoghuc it sounds like this PR is not the right fix? Can it be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants