Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-11011) extend vg facts #261

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

(MODULES-11011) extend vg facts #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/facter/volume_groups.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,12 @@
'vg_allocation_policy',
'vg_size',
'vg_free',
'vg_extent_size',
'vg_extent_count',
'vg_free_count',
]

output = Facter::Core::Execution.exec("vgs -o #{columns.join(',')} --noheading --nosuffix")
output = Facter::Core::Execution.exec("vgs -o #{columns.join(',')} --noheading --nosuffix --units m")
Puppet_X::LVM::Output.parse('vg_name', columns, output)
end
end
46 changes: 27 additions & 19 deletions spec/unit/facter/volume_groups_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
context 'when not on Linux' do
it 'is set to nil' do
Facter.fact(:kernel).expects(:value).at_least(1).returns('SunOs')
Facter.value(:volume_groups).should be_nil
expect(Facter.value(:volume_groups)).to be_nil
end
end

Expand All @@ -24,7 +24,7 @@
end

it 'is set to nil' do
Facter.value(:volume_groups).should be_nil
expect(Facter.value(:volume_groups)).to be_nil
end
end

Expand All @@ -36,26 +36,34 @@

it 'is able to resolve vgs' do
vgs_output = <<-OUTPUT
ZcFkEG-217a-nnc6-PvWx-oXou-7THt-XR6eci centos wz--n- writeable normal 19.51g 44.00m
tMqdQC-ukEx-bEft-bLk8-WoM1-jX0a-0p1rri tasks wz--n- writeable normal 3.99g 2.82g
ZcFkEG-217a-nnc6-PvWx-oXou-7THt-XR6eci centos wz--n- writeable normal 953864,00 126472,00 4,00 238466 31618
tMqdQC-ukEx-bEft-bLk8-WoM1-jX0a-0p1rri tasks wz--n- writeable normal 55540,00 6388,00 4,00 13885 1597
OUTPUT
vgs_output.lstrip!
Facter::Core::Execution.expects(:exec).at_least(1).returns(vgs_output)
Facter.value(:volume_groups).should include('centos' => {
'uuid' => 'ZcFkEG-217a-nnc6-PvWx-oXou-7THt-XR6eci',
'attr' => 'wz--n-', 'permissions' => 'writeable',
'allocation_policy' => 'normal',
'size' => '19.51g',
'free' => '44.00m'
},
'tasks' => {
'uuid' => 'tMqdQC-ukEx-bEft-bLk8-WoM1-jX0a-0p1rri',
'attr' => 'wz--n-',
'permissions' => 'writeable',
'allocation_policy' => 'normal',
'size' => '3.99g',
'free' => '2.82g',
})
expect(Facter.value(:volume_groups)).to include(
'centos' => {
'uuid' => 'ZcFkEG-217a-nnc6-PvWx-oXou-7THt-XR6eci',
'attr' => 'wz--n-', 'permissions' => 'writeable',
'allocation_policy' => 'normal',
'size' => '953864,00',
'free' => '126472,00',
'extent_size' => '4,00',
'extent_count' => '238466',
'free_count' => '31618'
},
'tasks' => {
'uuid' => 'tMqdQC-ukEx-bEft-bLk8-WoM1-jX0a-0p1rri',
'attr' => 'wz--n-',
'permissions' => 'writeable',
'allocation_policy' => 'normal',
'size' => '55540,00',
'free' => '6388,00',
'extent_size' => '4,00',
'extent_count' => '13885',
'free_count' => '1597',
},
)
end
end
end
Expand Down