Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to voxpupuli-rubocop #90

Merged
merged 1 commit into from
Jun 28, 2024
Merged

switch to voxpupuli-rubocop #90

merged 1 commit into from
Jun 28, 2024

Conversation

bastelfreak
Copy link
Contributor

@bastelfreak bastelfreak commented Jun 13, 2024

Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to merge this on my own as it would require a larger discussion within the team.
Have added it to the schedule for the next DevX triage however so a decision should be coming

Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If you could fix the rubocop error I would be happy to go ahead and merge.

@bastelfreak bastelfreak force-pushed the vp branch 2 times, most recently from 978c514 to 95e7c02 Compare June 28, 2024 10:53
@bastelfreak
Copy link
Contributor Author

@david22swan should be good now.

@david22swan david22swan merged commit e3c0a6e into puppetlabs:main Jun 28, 2024
5 of 6 checks passed
@danadoherty639 danadoherty639 added the maintenance maintenance label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants