(maint) - Write file type definitions to tempfile #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
force-pushed
the
maint-fix_nightlies
branch
3 times, most recently
from
f5f5649 to
26b825c
Compare
jordanbreen28
changed the title
jordanbreen28
force-pushed
the
maint-fix_nightlies
branch
2 times, most recently
from
6340b25 to
2b2d9aa
Compare
This commit now writes the file_type definitions to a tempfile as oppose to a file within the source code, as this was causing issues with CI. Using a tempfile is also better practice.
jordanbreen28
force-pushed
the
maint-fix_nightlies
branch
2 times, most recently
from
5e0053c to
c15b5cd
Compare
jordanbreen28
force-pushed
the
maint-fix_nightlies
branch
from
c15b5cd to
88238e1
Compare
gavindidrichsen
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR opts to aggregate and write the file type definitions to a tempfile rather than a file within the language servers root dir.
This was causing issues with the github runners for CI, and it is also a more elegant solution.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist