This repository has been archived by the owner on Jan 15, 2024. It is now read-only.
Spaces in Segments #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o0th
commented
Oct 5, 2016
•
o0th
commented
puntonim
reviewed
Oct 6, 2016
| @@ -18,6 +20,15 @@ def __init__(self, *args, **kwargs): | |||
| # Other segments are active if the config files states so. | |||
| self.active = config.SEGMENTS.get(class_name, False) | |||
|
|
|||
| if( config.SPACES ): | |||
| if class_name not in ['newline', 'root', 'divider', 'padding', 'exitcode']: | |||
There was a problem hiding this comment.
It's clear to me why NOT adding right and left spaces for newline, divider, padding. But why root and exitcode?
There was a problem hiding this comment.
for ExitCode there are already two spaces
self.text = ' ' + glyphs.CROSS + ' '
I don't like how it appear with more.
For the Root I think it's better this way so it seam a normal prompt line.
I think it's a matter of preference.
|
|
||
| if(class_name == 'git'): | ||
| self.ls = True | ||
| self.rs = False |
There was a problem hiding this comment.
It seemed to me there is already a whitespace on the right side, maybe I'm wrong. I will investigate after work.
puntonim
reviewed
Oct 11, 2016
|
Thank you @nimiq and sorry for the bad code. I'm not a python developer :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.