Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] custom jest output matchers #868

Draft
wants to merge 2 commits into
base: justin/tests-aws-typescript
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions aws-typescript/index.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
import * as pulumi from "@pulumi/pulumi";
import * as aws from "@pulumi/aws";
import * as awsx from "@pulumi/awsx";
import * as infra from "./infra";

// Create an AWS resource (S3 Bucket)
const bucket = new aws.s3.BucketV2("my-bucket");

// Export the name of the bucket
export const bucketName = bucket.id;
// Export the name of the bucket.
export const bucketName = infra.bucket.id;
10 changes: 10 additions & 0 deletions aws-typescript/infra.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import * as pulumi from "@pulumi/pulumi";
import * as aws from "@pulumi/aws";
import * as awsx from "@pulumi/awsx";

// Create an AWS resource (S3 Bucket) with tags.
export const bucket = new aws.s3.BucketV2("my-bucket", {
tags: {
"Name": "My bucket",
},
});
8 changes: 8 additions & 0 deletions aws-typescript/jest.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
/** @type {import('ts-jest').JestConfigWithTsJest} **/
module.exports = {
testEnvironment: "node",
transform: {
"^.+.tsx?$": ["ts-jest", {}],
},
setupFilesAfterEnv: ['./jest.matchers.js'],
};
45 changes: 45 additions & 0 deletions aws-typescript/jest.matchers.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
const { Output } = require("@pulumi/pulumi")

expect.extend({
async toEqualOutputOf(actual, expected) {
if (!actual instanceof Output) {
throw new Error(`Actual value must be an Output, got ${typeof actual}`)
}
return new Promise(resolve =>
actual.apply(unwrapped => {
if (this.equals(unwrapped, expected)) {
resolve({
pass: true,
})
} else {
resolve({
message: () => `expected ${this.utils.printExpected(expected)} to equal ${this.utils.printReceived(unwrapped)}`,
pass: false,
})
}
})
)
},

async apply(actual, applyFn) {
if (!actual instanceof Output) {
throw new Error(`Actual value must be an Output, got ${typeof actual}`)
}
return new Promise(resolve =>
actual.apply(async (...args) => {
try {
await applyFn(...args)
resolve({
pass: true,
})
} catch (e) {
resolve({
message: () => e.message,
pass: false,
})
}
})
)
},

})
6 changes: 6 additions & 0 deletions aws-typescript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,18 @@
"name": "${PROJECT}",
"main": "index.ts",
"devDependencies": {
"@types/jest": "^29.5.14",
"@types/node": "^18",
"jest": "^29.7.0",
"ts-jest": "^29.2.5",
"typescript": "^5.0.0"
},
"dependencies": {
"@pulumi/aws": "^6.0.0",
"@pulumi/awsx": "^2.0.2",
"@pulumi/pulumi": "^3.113.0"
},
"scripts": {
"test": "jest"
}
}
60 changes: 60 additions & 0 deletions aws-typescript/tests/infra.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
import * as pulumi from "@pulumi/pulumi";
import "jest";

// Test helper to convert a Pulumi Output to a Promise.
// This should only be used in tests.
function promiseOf<T>(output: pulumi.Output<T>): Promise<T> {
return new Promise(resolve => output.apply(resolve));
}

describe("infrastructure", () => {
// Define the infra variable as a type whose shape matches the that of the
// to-be-defined infra module.
let infra: typeof import("../infra");

beforeAll(() => {
// Put Pulumi in unit-test mode, mocking all calls to cloud-provider APIs.
pulumi.runtime.setMocks({
// Mock calls to create new resources and return a canned response.
newResource: (args: pulumi.runtime.MockResourceArgs) => {
// Here, we're returning a same-shaped object for all resource types.
// We could, however, use the arguments passed into this function to
// customize the mocked-out properties of a particular resource.
// See the unit-testing docs for details:
// https://www.pulumi.com/docs/iac/concepts/testing/unit/
return {
id: `${args.name}-id`,
state: args.inputs,
};
},

// Mock function calls and return an empty response.
call: (args: pulumi.runtime.MockCallArgs) => {
return {};
},
});
});

beforeEach(async () => {
// Dynamically import the infra module.
infra = await import("../infra");
});

// Example test. To run, uncomment and run `npm test`.
describe("bucket", () => {
it("must have a name tag", async () => {
const tags = await promiseOf(infra.bucket.tags);
expect(tags).toBeDefined();
expect(tags).toHaveProperty("Name");
});
it("must have the right tags", async () => {
await (expect(infra.bucket.tags) as any).toEqualOutputOf({ "Name": "My bucket oops" })
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't extend the expect type to know about our matchers, with that we won't need the cast to any here.

})
it("some apply thing", async () => {
await (expect(infra.bucket.tags) as any).apply((tags: any) => {
expect(tags).toBeDefined();
expect(tags).toHaveProperty("Name2");
})
})
});
});
5 changes: 1 addition & 4 deletions aws-typescript/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,5 @@
"noFallthroughCasesInSwitch": true,
"noImplicitReturns": true,
"forceConsistentCasingInFileNames": true
},
"files": [
"index.ts"
]
}
}