Go and Python codegen support symbols with hyphens in their names

[mattolenik]

Description

This change enables the fix for pulumi/crd2pulumi#43, wherein hyphens - were mishandled and led to generation of invalid Go and Python. For example, code such as func My-Thing() {} or class My-Thing.

This change improves the existing casing functions and extracts them to a new subpackage, cgstrings.

Resolves pulumi/crd2pulumi#43. When this change is merged go get -u will fix the crd2pulumi issue.

Checklist

• I have added tests that prove my fix is effective or that my feature works

[pulumi-bot]

Please view the results of the Downstream Codegen Tests Here

[pulumi-bot]

Changelog

[uncommitted] (2022-10-10)

[pulumi-bot]

Please view the results of the Downstream Codegen Tests Here

[iwahbe]

This looks good to me.

[mikhailshilkov]

@mattolenik @iwahbe Should we modify some programgen test cases to cover changes from this PR?

[Frassle]

This is called Title elsewhere

[mattolenik]

True, though there are package-specific implementations of Title that can (possibly) contain different logic. They get used like this:

// From pkg/codegen/docs/utils.go
func title(s, lang string) string {
	switch lang {
	case "go":
		return go_gen.Title(s)
	case "csharp":
		return dotnet.Title(s)
	default:
		return strings.Title(s)
	}
}

And since Title has the association (at least to me) of being like strings.Title which will uppercase multiple letters and not just the first one. Like foo bar becomes Foo Bar not Foo bar which is what we want here. So I figured a new name was clearer, but happy to take suggestions anyway of course

[Frassle]

That's fair enough reasoning to leave it as is

[Frassle]

Should we modify some programgen test cases to cover changes from this PR?

Or add new ones

[mikhailshilkov]

@iwahbe @AaronFriel should we take this PR over and bring it to the finish line?

[iwahbe]

@iwahbe @AaronFriel should we take this PR over and bring it to the finish line?

Yes we should. I'm on it.

[AaronFriel]

Convert to draft & remove reviewers until ready for review?

[iwahbe]

Convert to draft & remove reviewers until ready for review?

It should be ready for review now. @mattolenik addressed most of the feedback he got. I cleaned up the rest and regenerated the test case. It can be reviewed now.

[iwahbe]

bors r+

[bors]

Build succeeded:

• bors-ok