Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the make lint test part of weekly-pulumi-update #2818

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Jan 8, 2025

We don't need to run make lint test as part of creating the update PR, since these steps are already run as part of CI on the PR itself.

We don't need to run `make lint test` as part of creating the update PR, since these steps
are already run as part of CI on the PR itself.
@iwahbe iwahbe requested a review from a team January 8, 2025 12:58
@iwahbe iwahbe self-assigned this Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.64%. Comparing base (c83bfb2) to head (0d72494).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2818      +/-   ##
==========================================
- Coverage   68.65%   68.64%   -0.01%     
==========================================
  Files         325      325              
  Lines       41537    41537              
==========================================
- Hits        28516    28513       -3     
- Misses      11418    11420       +2     
- Partials     1603     1604       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flostadler flostadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Might be worth replacing this with renovate going forward

@iwahbe iwahbe merged commit c158e94 into master Jan 8, 2025
17 checks passed
@iwahbe iwahbe deleted the iwahbe/dont-test-weekly-pulumi-update branch January 8, 2025 16:16
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.100.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants