Improve the error messages in dynamic/internal/shim/grpcutil/replay #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was motivated while trying to add a test for #2815. Beyond adding comments, the major change is how the failure for differences in nested fields looks. It used to look like this: ```console go test -test.run \^TestConfigInDestroy\$ panic: fatal: An assertion has failed: field config does not match logged field \ &{{} [] [] 0x14000410008} != &{{} [] [] 0x14000410008} ``` Observe that both sides of the `!=` are identical. It now looks like this: ```console $ go test -test.run \^TestConfigInDestroy\$ panic: fatal: An assertion has failed: field "terraformv6_pulumi config msgpack" does not match logged field \ [134 83 71 ...] != [134 82 69 ...] ``` The path to the nested field is specified (`"terraformv6_pulumi config msgpack"`) and we see a difference in the value displayed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2817 +/- ##
==========================================
+ Coverage 68.63% 68.67% +0.04%
==========================================
Files 325 325
Lines 41536 41536
==========================================
+ Hits 28507 28524 +17
+ Misses 11423 11407 -16
+ Partials 1606 1605 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was motivated while trying to add a test for #2815. Beyond adding comments, the major change is how the failure for differences in nested fields looks. It used to look like this:
Observe that both sides of the
!=are identical.It now looks like this:
The path to the nested field is specified (
"terraformv6_pulumi config msgpack") and we see a difference in the value displayed.