Add a fallback for detailed diff replace decisions to ensure detailed diff is presentation-only

[VenelinMartinov]

This change adds a fallback for the detailed diff replace decision. This ensures that the detailed diff is presentation only.

If we fail to identify the reason for a replace in the detailed diff calculation we mark it against __meta, similar to what we did before:

pulumi-terraform-bridge/pkg/tfbridge/provider.go

Line 1262 in a952164

replaces = append(replaces, "__meta")

If we incorrectly identify a non-existent replace we demote it to an update/create/delete.

This is flagged behind the Accurate Previews flag.

I've stood up #2747 again as it got accidentally merged into another branch.

fixes #2674
fixes #2726

[VenelinMartinov]

This change is part of the following stack:

• Disable accurate previews for remainder of pf detailed diff tests #2756
  • Add a fallback for detailed diff replace decisions to ensure detailed diff is presentation-only #2757 ◀
    • Re-enable detailed diff replace tests for SDKv2 lists and sets #2751
      • Add SDKv2 Detailed Diff tests for Computed properties in sets #2740
        • Refactor SDKv2 set detailed diff tests to correct files #2741

_{Change managed by git-spice.}

[codecov]

Codecov Report

Attention: Patch coverage is 93.02326% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.63%. Comparing base (f2272e5) to head (3b77fce).
Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
pkg/tfbridge/detailed_diff.go	91.89%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2757   +/-   ##
=======================================
  Coverage   69.63%   69.63%           
=======================================
  Files         302      302           
  Lines       38736    38775   +39     
=======================================
+ Hits        26972    27001   +29     
- Misses      10247    10256    +9     
- Partials     1517     1518    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[VenelinMartinov]

It seems that TF is optimistic about replacing ForceNew properties with unknown and we were being pessimistic. This change ensures we match TF and ForceNew proeprties replaced with unknowns are now predicted NOT to cause a replacement.

We can add a workaround if we disagree here.

[VenelinMartinov]

I've stood up #2747 again as it got accidentally merged into another branch.

[iwahbe]

I'm pretty sure that I reviewed another version of this PR already.

[pulumi-bot]

This PR has been shipped in release v3.99.0.