Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test a special set diff case #2304

Merged
merged 7 commits into from
Aug 14, 2024
Merged

Test a special set diff case #2304

merged 7 commits into from
Aug 14, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Aug 9, 2024

Rebased and tidied up #2168

Fixes #2170

This change confirms that the bug discovered in pulumi/pulumi-meraki#97 is now fixed in the latest bridge via #2188

@t0yv0 t0yv0 mentioned this pull request Aug 9, 2024
@t0yv0 t0yv0 requested review from iwahbe and VenelinMartinov August 9, 2024 20:58
@t0yv0 t0yv0 marked this pull request as ready for review August 9, 2024 21:00
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 70.90909% with 16 lines in your changes missing coverage. Please review.

Project coverage is 56.79%. Comparing base (1e495a9) to head (1fcdd02).

Files Patch % Lines
...nal/testprovider/testbridge_resource_vlan_names.go 69.81% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2304      +/-   ##
==========================================
+ Coverage   56.78%   56.79%   +0.01%     
==========================================
  Files         362      363       +1     
  Lines       49822    49877      +55     
==========================================
+ Hits        28289    28326      +37     
- Misses      19988    20005      +17     
- Partials     1545     1546       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t0yv0 t0yv0 enabled auto-merge (squash) August 13, 2024 17:36
@t0yv0 t0yv0 merged commit 8b54f9b into master Aug 14, 2024
11 checks passed
@t0yv0 t0yv0 deleted the t0yv0/pf_set_diff branch August 14, 2024 09:53
@mjeffryes mjeffryes added this to the 0.108 milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PF wrong diff for set of objects
3 participants