Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of plugin framework types in favor of interface types #2184

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

guineveresaenger
Copy link
Contributor

This is mostly a migration/refactor from github.com/hashicorp/terraform-plugin-framework/types/ to github.com/hashicorp/terraform-plugin-framework/types/basetypes library. The main functional change is in type_schema.go's Elem() function.

Resolves #2119.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.70%. Comparing base (177b6c4) to head (b26c20d).
Report is 6 commits behind head on master.

Files Patch % Lines
pf/internal/schemashim/convert_type.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2184      +/-   ##
==========================================
- Coverage   60.65%   59.70%   -0.96%     
==========================================
  Files         350      354       +4     
  Lines       45930    46297     +367     
==========================================
- Hits        27859    27641     -218     
- Misses      16532    17108     +576     
- Partials     1539     1548       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to keep the types.* version in dynamic/test/pfprovider and internal/testprovider, since that is what users will write. Otherwise LGTM

@guineveresaenger guineveresaenger enabled auto-merge (squash) July 17, 2024 18:14
@guineveresaenger guineveresaenger merged commit 81c9d61 into master Jul 17, 2024
11 checks passed
@guineveresaenger guineveresaenger deleted the guin/2119 branch July 17, 2024 19:24
@mjeffryes mjeffryes added this to the 0.107 milestone Jul 24, 2024
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.88.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove instances of of types.* from PF
4 participants