Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating OIDC Issuer resource #484

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Creating OIDC Issuer resource #484

wants to merge 1 commit into from

Conversation

IaroslavTitov
Copy link
Contributor

@IaroslavTitov IaroslavTitov commented Jan 8, 2025 •
edited
Loading

Summary

  • Adding new OIDC Issuer resource
  • Adding OIDC client
  • Adding standard diff logic, to reuse in most (if not all!) resources - this would be used in Standardize Diff methods #481
  • @glena , please take a look, since I only know the basics when it comes to how OIDC works, let me know if this makes sense

Testing

  • Adding examples/integ tests in C#, TS, yaml
  • I had to add service-provider-test-org2 and service-provider-test-org3, since otherwise examples would collide with each other

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

  • index.OidcIssuer

Maintainer note: consult the runbook for dealing with any breaking changes.

@IaroslavTitov IaroslavTitov force-pushed the iaro/oidc branch 8 times, most recently from ac9aad3 to 85736bf Compare January 9, 2025 00:18
@IaroslavTitov IaroslavTitov marked this pull request as ready for review January 9, 2025 20:28
@glena
Copy link
Contributor

glena commented Jan 10, 2025

I think it looks ok but didnt dive into details, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanyeh seanyeh Awaiting requested review from seanyeh

@nyobe nyobe Awaiting requested review from nyobe

@dschaller dschaller Awaiting requested review from dschaller

@glena glena Awaiting requested review from glena

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IaroslavTitov @glena