Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating OIDC Issuer resource #484

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Creating OIDC Issuer resource #484

merged 1 commit into from
Jan 21, 2025

Conversation

IaroslavTitov
Copy link
Contributor

@IaroslavTitov IaroslavTitov commented Jan 8, 2025

Summary

Testing

  • Adding examples/integ tests in C#, TS, yaml
  • I had to add service-provider-test-org2 and service-provider-test-org3, since otherwise examples would collide with each other

Copy link

github-actions bot commented Jan 8, 2025

Does the PR have any schema changes?

Looking good! No breaking changes found.

New resources:

  • index.OidcIssuer

Maintainer note: consult the runbook for dealing with any breaking changes.

@IaroslavTitov IaroslavTitov force-pushed the iaro/oidc branch 9 times, most recently from 85736bf to 8528de1 Compare January 9, 2025 20:14
@IaroslavTitov IaroslavTitov marked this pull request as ready for review January 9, 2025 20:28
@glena
Copy link
Contributor

glena commented Jan 10, 2025

I think it looks ok but didnt dive into details, LGTM

@IaroslavTitov IaroslavTitov merged commit 56217dc into main Jan 21, 2025
24 checks passed
@IaroslavTitov IaroslavTitov deleted the iaro/oidc branch January 21, 2025 18:37
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (183d805) to head (acb31fc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #484   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a new resource oidc issuer
2 participants