Manage workflows with ci-mgmt #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
Closed
mjeffryes
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
It's a little hard to verify that all the release workflows are correct; but given that builds have been broken for a while and we know that this pattern works on a few other repos, I feel pretty good about shipping and just fixing any problems that crop up when we try to release.
blampe
added a commit
to pulumi/ci-mgmt
that referenced
this pull request
Apr 18, 2024
[kubernetes-cert-manager](https://github.com/pulumi/pulumi-kubernetes-cert-manager) is an older provider whose releases are currently [broken](https://github.com/pulumi/pulumi-kubernetes-cert-manager/actions/runs/7996599325). Rather than hacking together a one-time fix to unblock releases, it would be better to manage this repo via ci-mgmt so it can stay up-to-date with the rest of the ecosystem. This can merge after pulumi/pulumi-kubernetes-cert-manager#38, which updates the repo to work with these workflows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our GitHub workflows to use ones generated by ci-mgmt, and then updates Makefile targets and other pieces to build cleanly against those workflows.
Fixes #28
Fixes #27
Note the repo has some examples but these aren't hooked up to CI testing yet -- that is #26.