-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve remaining path conflicts in v3 #3855
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3855 +/- ##
==========================================
+ Coverage 57.26% 57.37% +0.11%
==========================================
Files 79 79
Lines 12469 12456 -13
==========================================
+ Hits 7140 7147 +7
+ Misses 4799 4766 -33
- Partials 530 543 +13 ☔ View full report in Codecov by Sentry. |
61f6212
to
71c54c1
Compare
71c54c1
to
8fa60df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Might be worth a quick sync call to make sure I understand all the moving parts.
e6f68fe
to
e9b020c
Compare
… ConnectionRaiBlocklist
5dd2f52
to
a372db5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good. Perhaps let's not close the tracking issue with this PR and leave it open until we've done the follow-up PR to add the aliases?
This PR has been shipped in release v2.84.0. |
Resolves #2495.
The first two commits bring the conflicts down to one or two, depending on how you count.
TODO
ConnectionRaiBlocklist
They made a mistake in 2024-0-01-preview, which is the v2 default version, in that they swapped the operationId’s of two resources.
Aliases