set RequireService to true for benchmarks #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VenelinMartinov
approved these changes
Feb 21, 2024
tgummerer
force-pushed
the
tg/require-service
branch
from
665e8f8 to
cce26eb
Compare
RequireService used to be the default for ProgramTest, in older pulumi/pkg versions. However when pkg got updated in 3d889a9#diff-8af729bc718ea271aecd1ceaae6d16e2119d7dfbe6a21b6e6f793b3b92fc65d1R10, running against the service started to be hidden behind a flag for better test isolation. We do however want to run benchmarks against the service, so set RequireService to true here to get that behaviour back.
tgummerer
force-pushed
the
tg/require-service
branch
from
cce26eb to
d096718
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RequireService used to be the default for ProgramTest, in older pulumi/pkg versions. However when pkg got updated in 3d889a9#diff-8af729bc718ea271aecd1ceaae6d16e2119d7dfbe6a21b6e6f793b3b92fc65d1R10, running against the service started to be hidden behind a flag for better test isolation.
We do however want to run benchmarks against the service, so set RequireService to true here to get that behaviour back.
/cc @t0yv0 @justinvp