Azure AKS with Container Registry and Keda example #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-example-tests on the PR |
| @@ -0,0 +1,21 @@ | |||
| MIT License | |||
There was a problem hiding this comment.
I think we don't put license files in other examples
| @@ -0,0 +1,21 @@ | |||
| import pulumi | |||
There was a problem hiding this comment.
Could you please add a copyright line to every file?
# Copyright 2016-2021, Pulumi Corporation. All rights reserved.
| addon_profiles={ | ||
| }, | ||
| agent_pool_profiles=[{ | ||
| 'count': config.node_count, |
There was a problem hiding this comment.
I'm curious if you'd be open to using the typed versions of arguments, similar to https://github.com/pulumi/examples/blob/master/azure-py-appservice-docker/__main__.py#L18
| @@ -0,0 +1,7 @@ | |||
| pulumi-azure-native>=1.0.0,<2.0.0 | |||
| pulumi-azuread>=4.0.0,<5.0.0 | |||
| pulumi-azure-native>=1.0.1, <2.0.0 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created an example of an AKS stack with an associated Container Registry, which is important for deploying applications that can't push images to Docker Hub.