eval: parallelize environment loading #393
Draft
+164
−828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add support for loading environments in parallel.
Parallelization is breadth-first, then depth-first. For example, given the following environments:
Environments
b
andc
would be loaded in parallel, then environmente
would be loaded, then environmentsf
andg
would be loaded in parallel. This simplifies the detection of cyclic imports and the collection of diagnostics.This improves performance for scenarios that are dominated by environment load time (e.g. import graphs with high degrees of fanout).
This is arguably a breaking change: prior to these changes, environments with cyclic imports would still be evaluated to the greatest extent possible. With these changes, the evaluator will terminate after attempting to load the import graph but before performing after evaluation in the case of an import cycle. I think that this break is worth the improvement.
Local benchmark results: