Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add developer setup instructions #63

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

seanyeh
Copy link
Contributor

@seanyeh seanyeh commented Jan 7, 2025

Depends on pulumi/docs#13757

Changes

  • Add setup/contributing docs
  • Add links to esc sdk api reference docs
  • Remove outdated/unused python readme

Fixes #25, #31, #30

@seanyeh seanyeh linked an issue Jan 7, 2025 that may be closed by this pull request
@seanyeh seanyeh force-pushed the syeh/add-build-instructions-readme branch 3 times, most recently from f0211c9 to 1f1f412 Compare January 7, 2025 20:18
@seanyeh seanyeh force-pushed the syeh/add-build-instructions-readme branch from 1f1f412 to 5348874 Compare January 7, 2025 20:19
@seanyeh seanyeh changed the title WIP - Add developer setup instructions WIP - Add developer/setup instructions Jan 7, 2025
@seanyeh seanyeh changed the title WIP - Add developer/setup instructions WIP - Add developer setup instructions Jan 7, 2025
@seanyeh seanyeh changed the title WIP - Add developer setup instructions Add developer setup instructions Jan 7, 2025
@seanyeh seanyeh marked this pull request as ready for review January 7, 2025 20:24
@seanyeh seanyeh requested review from a team and IaroslavTitov January 7, 2025 20:24
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing since this had outdated/misleading information. we may very well want to have READMEs at the language level (we currently don't for Go/Typescript), but I think for now we can remove this to reduce confusion

Copy link
Contributor

@IaroslavTitov IaroslavTitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, I would've had to dig though makefile again next time 😅

@seanyeh seanyeh linked an issue Jan 7, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate and link to the SDK docs for ESC Python docs have broken links Add setup/installation docs
2 participants