Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix namespace and add missing ResourceType attribute #52

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Fix namespace and add missing ResourceType attribute #52

merged 1 commit into from
Oct 18, 2021

Conversation

madsbacha
Copy link
Contributor

Fix issue #49 based on the following comment: #49 (comment)

The following changes have been made:

  • Add a missing ResourceType class to the bottom of the generated Utilities.cs file
  • Fix the namespace by passing the name through the dotnet.Title method

lblackstone
lblackstone approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikhailshilkov would you mind taking a look as well?

mikhailshilkov
mikhailshilkov approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@lblackstone lblackstone merged commit 34c1cc7 into pulumi:master Oct 18, 2021
@lblackstone
Copy link
Member

Thanks for the PR, @madsbacha!

@madsbacha madsbacha deleted the fix-csharp-namespace-and-attribute branch October 19, 2021 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblackstone lblackstone lblackstone approved these changes

@mikhailshilkov mikhailshilkov mikhailshilkov approved these changes

@viveklak viveklak Awaiting requested review from viveklak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madsbacha @lblackstone @mikhailshilkov