Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload code coverage #137

Merged
merged 4 commits into from
May 14, 2024
Merged

Upload code coverage #137

merged 4 commits into from
May 14, 2024

Conversation

blampe
Copy link
Contributor

@blampe blampe commented May 14, 2024

We were exec'ing a binary as part of our tests, which prevented us from collecting coverage. Instead, invoke the command directly as part of the test suite.

@blampe blampe added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label May 14, 2024
Copy link

codecov bot commented May 14, 2024

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@blampe blampe requested review from rquitales and EronWright May 14, 2024 21:12
@blampe blampe merged commit c7baa61 into master May 14, 2024
4 checks passed
@blampe blampe deleted the blampe/coverage branch May 14, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants