Skip to content

Commit

Permalink
address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
rquitales committed Sep 13, 2024
1 parent 2c843f7 commit b28b757
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions pkg/codegen/customresourcegenerator.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ func sanitizeReferenceName(fieldName string) string {
return "Arguments"
}

//We need to strip out any hyphens and underscores in the reference.
// We need to strip out any hyphens and underscores in the reference.
fieldName = cgstrings.Unhyphenate(fieldName)
fieldName = cgstrings.ModifyStringAroundDelimeter(fieldName, "_", cgstrings.UppercaseFirst)

Expand Down Expand Up @@ -209,7 +209,7 @@ func crdToOpenAPI(crd *extensionv1.CustomResourceDefinition) ([]*spec.Swagger, e
return openAPIManifests, nil
}

// fillDefaultNames sets the default names for the CRD if they are not specified.
// setCRDDefaults sets the default names for the CRD if they are not specified.
// This allows the OpenAPI builder to generate the swagger specs correctly with
// the correct defaults.
func setCRDDefaults(crd *extensionv1.CustomResourceDefinition) {
Expand Down
2 changes: 1 addition & 1 deletion tests/crds_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ func TestCRDsFromUrl(t *testing.T) {
})
}

// TODO: Also run compilation tests for java and python.
// TODO(#145): Also run compilation tests for java and python.
compileValidationFn := map[string]func(t *testing.T, path string){
"nodejs": validateNodeCompiles,
"go": validateGolangCompiles,
Expand Down

0 comments on commit b28b757

Please sign in to comment.