Skip to content

Commit

Permalink
Revert change that added default paths (#95)
Browse files Browse the repository at this point in the history
* Revert change that added default paths

This inadvertantly caused all languages to be generated (because their
path being set implies so)

* Add changelog
  • Loading branch information
mattolenik authored Jul 21, 2022
1 parent b298030 commit 1eef2ce
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
CHANGELOG
=========

## 1.2.1 (2022-06-16)
## 1.2.2 (2022-07-20)
- Fix regression that caused code in all languages to be generated regardless of selection.

## 1.2.1 (2022-07-19)
This release is a refactor with no user-affecting changes.
- Create public interface for codegen in the `pkg/codegen` namespace
while placing internal utilities under `internal/`
Expand Down
8 changes: 4 additions & 4 deletions cmd/root.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,10 @@ func Execute() error {
f.StringVarP(&nodejsSettings.PackageName, "nodejsName", "", codegen.DefaultName, "name of generated NodeJS package")
f.StringVarP(&pythonSettings.PackageName, "pythonName", "", codegen.DefaultName, "name of generated Python paclkage")

f.StringVarP(&dotNetSettings.OutputDir, "dotnetPath", "", "crds/dotnet", "optional .NET output dir")
f.StringVarP(&goSettings.OutputDir, "goPath", "", "crds/go", "optional Go output dir")
f.StringVarP(&nodejsSettings.OutputDir, "nodejsPath", "", "crds/nodejs", "optional NodeJS output dir")
f.StringVarP(&pythonSettings.OutputDir, "pythonPath", "", "crds/python", "optional Python output dir")
f.StringVarP(&dotNetSettings.OutputDir, "dotnetPath", "", "", "optional .NET output dir")
f.StringVarP(&goSettings.OutputDir, "goPath", "", "", "optional Go output dir")
f.StringVarP(&nodejsSettings.OutputDir, "nodejsPath", "", "", "optional NodeJS output dir")
f.StringVarP(&pythonSettings.OutputDir, "pythonPath", "", "", "optional Python output dir")

f.BoolVarP(&dotNetSettings.ShouldGenerate, "dotnet", "d", false, "generate .NET")
f.BoolVarP(&goSettings.ShouldGenerate, "go", "g", false, "generate Go")
Expand Down

0 comments on commit 1eef2ce

Please sign in to comment.