Simplify provider-ci makefile #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rewrite example provider testing targets to be more linear and easy to follow. - Move "test-workflows" to "test-providers". - Move config files for testing into each provider repo - named .ci-mgmt.yaml - just like the real repo. - Move temp linting repo into the bin directory which is fully ignored as it's just temp files.
danielrbradley
force-pushed
the
refactor-makefile
branch
from
b3e395e to
e3f8626
Compare
danielrbradley
force-pushed
the
refactor-makefile
branch
from
d86a962 to
f54dd74
Compare
Merged
thomas11
reviewed
Jun 25, 2024
| rm -rf bin/test-provider/$*/repo/.git | ||
|
|
||
| # Fetch the latest .ci-mgmt.yaml from the provider repositories ready for testing. | ||
| update-provider-configs: |
There was a problem hiding this comment.
Who/what will be calling this target, and when?
There was a problem hiding this comment.
Just whenever we want to update our test data - would be manual right now but could create a CI job to call this. It seems like this hasn't been done in quite a while - see the follow-up PR stacked on this one.
thomas11
approved these changes
Jun 25, 2024
- Use path filters to only test things that have changed. - Only run downstream tests for provider-ci.
danielrbradley
force-pushed
the
refactor-makefile
branch
from
0c3395b to
f6a87e7
Compare
The ci-mgmt makefiles themselves don't use pulumictl - we only need this when calling `make upstream` during rollouts.
- Use explicit tag & cache. - Use custom token.
danielrbradley
force-pushed
the
refactor-makefile
branch
from
14e01d0 to
175e5b6
Compare
danielrbradley
added a commit
that referenced
this pull request
Jun 25, 2024
Update the test configs to match the real repos by running `make update-provider-configs`, then re-run `make` to re-generate. Stacked on #993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite example provider testing targets to be more linear and easy to follow. This is a clean-up in order to add more providers to test as we start to migrate new ones in (i.e. native providers & components).
This is now slightly faster for running both clean and repeated runs of
make.Clean run on
make:2.40s user 2.76s system 159% cpu 3.224 total1.39s user 1.77s system 127% cpu 2.480 totalRepeated run of
make:1.63s user 1.99s system 231% cpu 1.561 total0.63s user 0.95s system 243% cpu 0.649 total