Fix release verification to cover Mac OS appropriately #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquitales
reviewed
Jan 16, 2025
| @@ -64,7 +64,7 @@ jobs: | |||
| # Expression expands to ["ubuntu-latest","windows-latest"] or ["ubuntu-latest","windows-latest","macos-latest"] | |||
| # GitHub expressions don't have 'if' statements, so we use a ternary operator to conditionally include the MacOS runner suffix. | |||
| # See the docs for a similar example to this: https://docs.github.com/en/actions/learn-github-actions/expressions#fromjson | |||
| runner: ${{ fromJSON(format('["ubuntu-latest","windows-latest"{0}]', github.event.inputs.enableMacRunner == 'true' && ',"macos-latest"' || '')) }} | |||
| runner: ${{ fromJSON(format('["ubuntu-latest","windows-latest"{0}]', inputs.enableMacRunner && ',"macos-latest"' || '')) }} # | |||
There was a problem hiding this comment.
If only we had a more readable way to express this.
There was a problem hiding this comment.
There could be a more readable way but testing is hard, so i just tested this one and would like to roll with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that release verification runs jobs on MacOS as intended.
Example release in pulumi/pulumi-xyz#756 - see https://github.com/pulumi/pulumi-xyz/actions/runs/12817331557
Looks like there were a few bugs in the code: