Only add nuget source for dotnet tests #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow-up to #1063 The nuget command fails if dotnet wasn't installed.
ringods
approved these changes
Sep 12, 2024
danielrbradley
added a commit
that referenced
this pull request
Sep 13, 2024
Mirror the fix for #1079 into the nightly, main, prerelease and release jobs.
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
Mirror the fix for #1079 into the nightly, main, prerelease and release jobs. Test is the only core part of our workflow which has not been deduplicated and so we have to copy fixes into all the different workflows. Spotted from issue pulumi/pulumi-azure#2393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1063
The nuget command fails if dotnet wasn't installed.
Example failure: https://github.com/pulumi/pulumi-azure/actions/runs/10815039270/job/30003728480?pr=2387
This only affects providers which have enabled
freeDiskSpaceBeforeTestbecause they will have a default version of dotnet available, and therefore also wasn't caught by the downstream tests.For the sake of consistency, we'll also only configure the pip virtualenv if we're atually running python tests.