Do not delete provider custom workflows in make ci-mgmt #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flostadler
reviewed
Sep 5, 2024
| @@ -208,7 +208,7 @@ bin/pulumi-java-gen: .pulumi-java-gen.version | |||
| # - Run make ci-mgmt to apply the change locally. | |||
| # | |||
| ci-mgmt: .ci-mgmt.yaml | |||
| rm -f .github/workflows/*.yml # Copied from update-workflows.yml | |||
| find pulumi-$(PACK)/.github/workflows/*.yml -type f ! -name "$(PACK)*.yml" -delete | |||
There was a problem hiding this comment.
Shouldn't this exclude the pulumi-$(PACK)/ prefix?
Suggested change
| find pulumi-$(PACK)/.github/workflows/*.yml -type f ! -name "$(PACK)*.yml" -delete | |
| find .github/workflows/*.yml -type f ! -name "$(PACK)*.yml" -delete |
t0yv0
force-pushed
the
t0yv0/fix-make-ci-mgmt
branch
from
a811307 to
9b4c0a0
Compare
|
Possibly yea - can I have this in the meanwhile? We're trying to keep the AWS workflow alive for running upstream tests. |
danielrbradley
approved these changes
Sep 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
flostadler
approved these changes
Sep 18, 2024
We introduced a notion of provider-custom workflow files, such as:
aws-upstream-tests.yml
Currently CI knows to not delete them, but `make ci-mgmt` target still does. This PR fixes this so that `make ci-mgmt`
target matches the behavior of CI workflows.
t0yv0
force-pushed
the
t0yv0/fix-make-ci-mgmt
branch
from
9b4c0a0 to
47113c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced a notion of provider-custom workflow files, such as:
Currently CI knows to not delete them, but
make ci-mgmttarget still does. This PR fixes this so thatmake ci-mgmttarget matches the behavior of CI workflows.