Fix golangci-lint warnings #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade golangci-lint to v1.60 (#1062) surfaced new warnings about deprecations. - The configuration option `run.skip-files` is deprecated, please use `issues.exclude-files`. - The linter named "megacheck" is deprecated. It has been split into: gosimple, staticcheck, unused.
danielrbradley
added a commit
to pulumi/pulumi-azure
that referenced
this pull request
Aug 29, 2024
- Fix config warnings, as backported into ci-mgmt: pulumi/ci-mgmt#1064 - The configuration option run.skip-files is deprecated, please use issues.exclude-files. - The linter named "megacheck" is deprecated. It has been split into: gosimple, staticcheck, unused. - Remove go:linkname which was added when we weren't maintaining patches and so had to use a compiler hack to set a value. This variable no longer exists so has no effect. Reported error: SA9009: ineffectual compiler directive due to extraneous space: "// go:linkname is not widely used outside the standard library, but allows us to" (staticcheck)
danielrbradley
added a commit
to pulumi/pulumi-azure
that referenced
this pull request
Aug 29, 2024
- Fix config warnings, as backported into ci-mgmt: pulumi/ci-mgmt#1064 - The configuration option run.skip-files is deprecated, please use issues.exclude-files. - The linter named "megacheck" is deprecated. It has been split into: gosimple, staticcheck, unused. - Remove go:linkname which was added when we weren't maintaining patches and so had to use a compiler hack to set a value. This variable no longer exists so has no effect. Reported error: SA9009: ineffectual compiler directive due to extraneous space: "// go:linkname is not widely used outside the standard library, but allows us to" (staticcheck)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run.skip-filesis deprecated, please useissues.exclude-files.