Test master & release workflow on PR merge #1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
danielrbradley
commented
Aug 22, 2024
danielrbradley
commented
- Use a merge queue to ensure XYZ is able to be released with the latest ci-mgmt changes before the change is committed into master to be rolled out to all other providers.
- The next step here would be to auto-tag the release and verify that also completes correctly.
- Use a merge queue to ensure XYZ is able to be released with the latest ci-mgmt changes before the change is committed into master to be rolled out to all other providers. - The next step here would be to auto-tag the release and verify that also completes correctly.
danielrbradley
force-pushed
the
test-release-on-merge
branch
from
749de58 to
a1bafa9
Compare
iwahbe
approved these changes
Aug 23, 2024
provider-ci/internal/pkg/templates/bridged-provider/.github/workflows/release.yml
Show resolved
Hide resolved
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 23, 2024
- Use a merge queue to ensure XYZ is able to be released with the latest ci-mgmt changes before the change is committed into master to be rolled out to all other providers. - The next step here would be to auto-tag the release and verify that also completes correctly.
- Add workflow name. - Just cut patch releases instead of minor releases. `git ls-remote --tags "[email protected]:pulumi/pulumi-xyz.git"` failed with: [email protected]: Permission denied (publickey). fatal: Could not read from remote repository. So, adding a checkout of the pulumi-xyz repo to get the creds set up.
danielrbradley
force-pushed
the
test-release-on-merge
branch
from
a1bafa9 to
bb0634a
Compare
danielrbradley
changed the title
danielrbradley
force-pushed
the
test-release-on-merge
branch
from
aaa0475 to
15360d3
Compare
- Required checks apply to both pull_request and merge_group runs, so we need exactly the same required names.
- Move name and trigger to top of file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.