Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #29

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Fix CI #29

merged 2 commits into from
Aug 12, 2024

Conversation

savetheclocktower
Copy link
Contributor

Two main causes of the CI breakage:

  1. Latest ESLint now expects the new config file format, so the fixture directories now include an eslint.config.js file.
  2. Latest ESLint expects structuredClone to be present; it was added in Node 17, so we'll make Node 18 the oldest version of Node we test on.

(I don't think this package needs an official support policy regarding Node; the deal is that, if your version of ESLint (>= version 8) works on the command line for your project, it'll work in this package, since the point is to use the same version of Node to run the worker process as you've got set up for your project.)

Copy link
Collaborator

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@savetheclocktower savetheclocktower merged commit bb5137b into main Aug 12, 2024
5 checks passed
@savetheclocktower savetheclocktower deleted the fix-ci-3 branch August 12, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants