Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enable setting for ability to do project-specific disabling #26

Merged
merged 4 commits into from
Aug 12, 2024

Conversation

savetheclocktower
Copy link
Contributor

I sometimes make contributions to projects which have very opinionated, noisy, or outdated ESLint configs. Sometimes they have silly ESLint plugins that I don't want to install. Sometimes I'm running pulsar-ide-typescript-alpha and the linting I'm getting from typescript-language-server is more than enough.

These are all scenarios in which I'd want a quick way to disable linting on an entire project (even when it's set up for ESLint) without disabling the package altogether. With an explicit Enable option, I can easily configure a project-specific override with project-config/atomic-management or by adding "enable": false to a .linter-eslint file.

Copy link
Collaborator

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes, one little comment

package.json Outdated Show resolved Hide resolved
@savetheclocktower
Copy link
Contributor Author

The test failures are all on the CI-only tests; looks like something about the environment setup isn't quite right, and the job isn't giving us useful error messages. I'll see if I can track down the root cause, but in the meantime I'm fine with landing this if you are.

@savetheclocktower savetheclocktower merged commit 333301d into main Aug 12, 2024
5 checks passed
@savetheclocktower savetheclocktower deleted the enable-option branch August 12, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants