Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app-rebuild logic #698

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix app-rebuild logic #698

merged 1 commit into from
Dec 5, 2024

Conversation

gerrod3
Copy link
Collaborator

@gerrod3 gerrod3 commented Dec 5, 2024

Lets see if I caught all the errors in this new app logic.

  1. Missing packaging requirement for the check_up_to_date script
  2. Fixed the echo message for if we are going to rebuild
  3. Reverted back to old logic for finding app-version/branch since new way didn't work for nightly (pip freeze will give you the commit not the version like pip list)
  4. Use the appropriate output redirect '>' instead of '>>' for versions.freeze (this was causing the multi-line output issue)
  5. Added token so release workflow can properly remove the old cache

@gerrod3 gerrod3 merged commit 33ec895 into pulp:latest Dec 5, 2024
6 checks passed
@gerrod3 gerrod3 deleted the app-fixes branch December 5, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant