Fix release failing when there were duplicate tags #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can get duplicate tags right after we do a release and not immediately merge the version bump in pulpcore. Nightly will then have the same y-version as the latest release which creates duplicate tags in our tagging logic. Now we de-dup the tags before publishing.
mdellweg
approved these changes
Oct 9, 2024
| @@ -130,6 +130,7 @@ jobs: | |||
| tags="${tags} ${NIGHTLY_VERSION} ${NIGHTLY_BRANCH} latest" | |||
| fi | |||
| fi | |||
| tags=$(echo "${tags}" | xargs -n1 | sort -u | xargs) | |||
There was a problem hiding this comment.
I did not know, xargs can be used that way.
There was a problem hiding this comment.
according to man xargs:
[...] and executes the command (default is echo) [...]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can get duplicate tags right after we do a release and not immediately merge the version bump in pulpcore. Nightly will then have the same y-version as the latest release which creates duplicate tags in our tagging logic. Now we de-dup the tags before publishing.