Skip to content

Commit

Permalink
Remove nightly matrix scenario from PR CI
Browse files Browse the repository at this point in the history
  • Loading branch information
gerrod3 committed Oct 16, 2024
1 parent 801dc23 commit d1b0b2b
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 20 deletions.
4 changes: 0 additions & 4 deletions .github/actions/test_image/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ inputs:
image_name:
description: 'Name of the image to be tested'
required: true
image_variant:
description: 'Stable or nightly build'
required: true
default: 'stable'
app_branch:
description: 'The branch the app was built on'
required: true
Expand Down
16 changes: 1 addition & 15 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,20 +50,8 @@ jobs:
base-images:
runs-on: ubuntu-latest
outputs:
image_variants: "${{ steps.image_variants.outputs.image_variants }}"
base_cache_key: "${{ steps.build_base_images.outputs.base_cache_key }}"
steps:
# We do not want to build nightly images unless it's a PR to the latest branch,
# or a branch/dispatch build on the latest branch.
- name: Set the list of image_variants for later jobs
id: image_variants
run: |
if [ "${{ github.base_ref }}" == "latest" ] || [ "${{ github.ref_name }}" == "latest" ]; then
echo "image_variants=[\"nightly\",\"stable\"]" >> "$GITHUB_OUTPUT"
else
echo "image_variants=[\"stable\"]" >> "$GITHUB_OUTPUT"
fi
- uses: actions/checkout@v4

- name: Build base images
Expand All @@ -81,7 +69,6 @@ jobs:
strategy:
fail-fast: false
matrix:
image_variant: ${{ fromJSON(needs.base-images.outputs.image_variants) }}
image_name:
- pulp-minimal
- pulp
Expand All @@ -95,14 +82,13 @@ jobs:
uses: "./.github/actions/build_image"
with:
image_name: ${{ matrix.image_name }}
image_variant: ${{ matrix.image_variant }}
image_variant: "stable"
image_cache_key: ${{ needs.base-images.outputs.base_cache_key }}

- name: Test App Image
uses: "./.github/actions/test_image"
with:
image_name: ${{ matrix.image_name }}
image_variant: ${{ matrix.image_variant }}
app_branch: ${{ steps.build_image.outputs.app_branch }}

- name: Logs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -176,10 +176,10 @@ jobs:
image_cache_key: ${{ needs.base-images.outputs.base_cache_key }}

- name: Test App Image
if: matrix.image_variant != 'nightly'
uses: "./.github/actions/test_image"
with:
image_name: ${{ matrix.image_name }}
image_variant: ${{ matrix.image_variant }}
app_branch: ${{ steps.build_image.outputs.app_branch }}

- name: Set tags
Expand Down

0 comments on commit d1b0b2b

Please sign in to comment.