Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better logging #1330

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Add better logging #1330

merged 1 commit into from
Feb 28, 2025

Conversation

hectorcorrea
Copy link
Member

@hectorcorrea hectorcorrea commented Feb 28, 2025

I have the sneaking suspicion that the code that updates the FileInventoryRequest is taking too long to complete.

Twice I have seen the line in the log that indicates that the file has been exported to disk and yet had to wait what feel like a long time to see the record in the database for the file inventory (which is what makes the result visible to the users) get updated.

Notice the completion time for the job (16:48) is 15 minutes after the file was saved to disk (16:33):

#<FileInventoryRequest:0x00007effb9058cb8
  id: 9,
  user_id: 51,
  project_id: 8,
  job_id: "42aed9b9-08c8-4fd0-b649-7899b62b95bc",
  completion_time: Fri, 28 Feb 2025 16:48:57.095634000 UTC +00:00,
deploy@tigerdata-prod2:/opt/tigerdata/current$ ls -la /.../42aed9b9-08c8-4fd0-b649-7899b62b95bc.csv
-rw-rw-r-- 1 nobody nogroup 161322086 Feb 28 16:33 /.../42aed9b9-08c8-4fd0-b649-7899b62b95bc.csv

This PR does not fix the issue, but at least will give us some hard data rather than relying on my hunch.

Related to #1274

@jrgriffiniii jrgriffiniii merged commit 61fa34d into main Feb 28, 2025
2 checks passed
@jrgriffiniii jrgriffiniii deleted the file-inventory-log branch February 28, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants